Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Migration to Robyn" #16

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Revert "Migration to Robyn" #16

merged 1 commit into from
Aug 23, 2024

Conversation

AmaseCocoa
Copy link
Member

@AmaseCocoa AmaseCocoa commented Aug 23, 2024

Reverts #14

理由

ASGI等を利用しないで単独で動作できることと速度に魅力を感じて移行したけどいろいろ面倒な部分 (後述)があることが分かったので (その辺りが充実したりHolo側の実装でどうにかなるようになれば戻る可能性はあります)

それでもRobyn自体は全然良かったので別のプロジェクトで使う可能性はある。

面倒な部分の例

  • uvicornみたいなログの取り方はどうしてもできない (granianとかで使うようの関数を流用しようとしてもFastAPIのmiddlewareにあるcall_nextのような関数がないので完全なログが出力できない)
  • (これは面倒な理由ではない、Robynのドキュメントはわかりにくくなかったし慣れの問題) 結局FastAPIのほうが慣れてて書きやすい等の理由もある

@AmaseCocoa AmaseCocoa merged commit cddf291 into master Aug 23, 2024
0 of 2 checks passed
@AmaseCocoa AmaseCocoa deleted the revert-14-robyn branch August 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant